-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
responsive navbar #215
responsive navbar #215
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/acmucsd/main-website/9vudr79Bq3FAetschTCbo3doEjSm |
<div className={`${s.bar1} ${menuOpen && s.open}`} /> | ||
<div className={`${s.bar2} ${menuOpen && s.open}`} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo probably semantically better to use an inline svg and animate that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i tried to do this and nothing would work so i'm going to ignore for now unless anyone thinks its significant enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking pretty good, one major change needed with the ordering of the links, aside from that some questions on commenting but i'll leave it up to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent, this is perfect
* completed rough event card * possible fix * remove console log * fix padding (#213) * fix text colors for different orgs * responsive navbar (#215) * started responsive navbar * commit typing * finish navbar * move navbar styles to component level module * commit module typing * use proper color variables * use seconds for transitions * fix navlink order * fix easing functions * add css comments * Fetch data for board cards at build time server-side (#211) * fetch board data from spreadsheet and populate * moved code to api util function * isr generate date once a day * delete hardcoded data * fixed board card fetch * fixes * Update BoardAPI.ts * dumb fix * Update Navbar.module.scss (#216) * fix navbar with events tab * optional facebook url
* completed rough event card * possible fix * remove console log * fix padding (#213) * fix text colors for different orgs * responsive navbar (#215) * started responsive navbar * commit typing * finish navbar * move navbar styles to component level module * commit module typing * use proper color variables * use seconds for transitions * fix navlink order * fix easing functions * add css comments * Fetch data for board cards at build time server-side (#211) * fetch board data from spreadsheet and populate * moved code to api util function * isr generate date once a day * delete hardcoded data * fixed board card fetch * fixes * Update BoardAPI.ts * dumb fix * Update Navbar.module.scss (#216) * fix navbar with events tab * optional facebook url * close on click (#218) * add event card filters * make footer icon type pointer hi ronak - chris * breakpoint as variable
* added route for events page * deleted everything * Events cards (#214) * completed rough event card * possible fix * remove console log * fix padding (#213) * fix text colors for different orgs * responsive navbar (#215) * started responsive navbar * commit typing * finish navbar * move navbar styles to component level module * commit module typing * use proper color variables * use seconds for transitions * fix navlink order * fix easing functions * add css comments * Fetch data for board cards at build time server-side (#211) * fetch board data from spreadsheet and populate * moved code to api util function * isr generate date once a day * delete hardcoded data * fixed board card fetch * fixes * Update BoardAPI.ts * dumb fix * Update Navbar.module.scss (#216) * fix navbar with events tab * optional facebook url * Event filters (#219) * completed rough event card * possible fix * remove console log * fix padding (#213) * fix text colors for different orgs * responsive navbar (#215) * started responsive navbar * commit typing * finish navbar * move navbar styles to component level module * commit module typing * use proper color variables * use seconds for transitions * fix navlink order * fix easing functions * add css comments * Fetch data for board cards at build time server-side (#211) * fetch board data from spreadsheet and populate * moved code to api util function * isr generate date once a day * delete hardcoded data * fixed board card fetch * fixes * Update BoardAPI.ts * dumb fix * Update Navbar.module.scss (#216) * fix navbar with events tab * optional facebook url * close on click (#218) * add event card filters * make footer icon type pointer hi ronak - chris * breakpoint as variable * remove old files * Event details (#220) * wire up dynamic routes from api and link from corresponding card * rename /event to /events * format event name in url * mobile at 960 * event page details + calendar actions * small fixes * fix committee name and css * remove unused link for now * fix replaceAll not supported * generate and cache paths server side * add support for viewing past events * fix some comments * SEO event link previews * pass entire event directly to event card * update seo description * mobile dropdown functioning * fix 2-way binding
Description
Rewrote Navbar component completely to simplify code structure for future maintainability, reduced re-renderings of ACM Logo, designed responsive mobile menu animation and hamburger icon opening/closing, changed background to white to match website theme, and moved Navbar code to Sass modules as part of our gradual move to Next.js
Type of change
How Has This Been Tested?
Checklist: